search

akaszynski / keepa

Python Keepa.com API
https://keepaapi.readthedocs.io/en/latest/
Apache License 2.0
241 stars 77 forks source link

interface.py #119

Closed Praveensenpai closed 1 year ago

Praveensenpai commented 1 year ago

used inbuilt function and simplified some statements

chocobn69 commented 1 year ago

Why did you change code format ?? This commit is unreadable

akaszynski commented 1 year ago

Hi @Praveensenpai,

Went through this. I should document this better, but we're using black as an auto code formatter. This takes any "creative" style out of code styling and eliminates the need for any sort of style related PRs (at least for the source itself. You can try this yourself with (in the root of the repo):

pip install pre-commit
pre-commit run --all-files

The pre-commit configuration is in .pre-commit-config.yaml, and we use that to automate any code styling. If you install pre-commit as a "pre-commit hook" it will run automatically before pushing your code. For example:

$ pre-commit install
$ commit -am "my new feature"
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
codespell................................................................Passed
pydocstyle...........................................(no files to check)Skipped

Knowing that, would you mind resubmitting this PR after running black via pre-commit?