akate / dokuwiki

The DokuWiki Open Source Wiki Engine
http://www.dokuwiki.org
GNU General Public License v2.0
3 stars 1 forks source link

ACL check for media uploads doesn't check subnamespaces #61

Open michitux opened 13 years ago

michitux commented 13 years ago

The ACL check in ajax_mediaupload() does only check $NS, but the actual file is written to $NS:$id and $id can contain further namespaces so users can actually upload into protected subnamespaces and even overwrite files there if they have the permissions for the parent namespace. I think either the ACL check should check the namespace of $NS:$id or $id mustn't contain further namespaces.