leading spaces causing failed match in Makefile

[qbancoffee]

There was a problem with the Makefile that caused incorrect checksum during file creations. The version of edid-decode I'm using has leading spaces in front of the word "Checksum" causing the line not to match " Checksum" and extracting the correct checksum.

removed local -a from the following line. local -a lines=('/ '"$name: $REPLY"' /') #

[akatrevorjay]

Nice find! Thanks!

[qbancoffee]

That one drove me crazy!

On 03/13/2017 04:47 PM, Trevor Joynson wrote:

Nice find! Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akatrevorjay/edid-generator/pull/4#issuecomment-286238449, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfHnvonXGqIh5uykdw4tOfqvEKN76vJks5rlatYgaJpZM4LdV1V.

[qbancoffee]

Made the changes 4 you.

On 03/13/2017 04:49 PM, Trevor Joynson wrote:

@akatrevorjay requested changes on this pull request.

---

In modeline2edid https://github.com/akatrevorjay/edid-generator/pull/4#discussion_r105767636:

    HSYNC_POL "$hsync_polarity"

VSYNC_POL "$vsync_polarity" )

• local -a lines=('/ '"$name: $REPLY"' /')
• lines=('/ '"$name: $REPLY"' /') # removed local -a

This must be a version dependent thing. Can you leave the |local| but just remove the |-a| and I'll accept?

---

In modeline2edid https://github.com/akatrevorjay/edid-generator/pull/4#discussion_r105767783:

    lines+=("#define $k ${defines[$k]}")

• echo ${defines[TIMING_NAME]}

If you could remove these debug statements that would also be rad if you don't mind?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akatrevorjay/edid-generator/pull/4#pullrequestreview-26662835, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfHniH4E0geSQyRFSbtW6rTexECsd8tks5rlavIgaJpZM4LdV1V.

[akatrevorjay]

Thanks so much!