akaunting / laravel-firewall

Web Application Firewall (WAF) package for Laravel
https://akaunting.com
MIT License
941 stars 104 forks source link

Set the default value of the `firewall.all_middleware` config #31

Closed vlasscontreras closed 4 years ago

vlasscontreras commented 4 years ago

Prevent errors during installation due the config value being null before publishing config files.

denisdulici commented 4 years ago

The current one works fine for me on a clean Laravel installation:

Screenshot_339

Please, provide the steps to reproduce the issue.

vlasscontreras commented 4 years ago

If affects projects with cached config entries, reproducible with the following flow:

laravel new app && cd app
php artisan config:cache
composer require akaunting/firewall
denisdulici commented 4 years ago

Then your workflow is wrong, you should first install firewall then cache config.

vlasscontreras commented 4 years ago

Not all projects start having this package because it could have been discovered even after going to production and is most likely to have cached config. That's why I suggested this change.

Anyway, thank you for your feedback.