search

akaunting / laravel-money

Currency formatting and conversion package for Laravel
https://akaunting.com
MIT License
732 stars 101 forks source link

Revert "Use new static instead of new self" #79

Closed denisdulici closed 1 year ago

denisdulici commented 1 year ago

Reverts akaunting/laravel-money#77

ralphjsmit commented 1 year ago

@denisdulici, just curious, did this cause any issues? All tests etc passed.

denisdulici commented 1 year ago

Do we still need it after making the class Macroable https://github.com/akaunting/laravel-money/pull/76?

ralphjsmit commented 1 year ago

Yes, because the Macroable class doesn't support implementing additional interfaces. For example, to extend the Money and Currency classes and make the work with Livewire using the Wireable interface.