akauppi / GroundLevel-firebase-es

[ANCHORED] Stencil for operational web apps
https://groundlevel-sep22.web.app/
Other
23 stars 3 forks source link

Place the right Security Rules back! #46

Closed akauppi closed 3 years ago

akauppi commented 3 years ago

Once https://github.com/firebase/firebase-js-sdk/issues/4795 is resolved, change this back:

      allow read: if true   // HACK! CHANGE! so that development can continue! AK 15-Apr-21
      //allow read: if isMember() && (!isRemoved() || isAuthor())
        //&& validProject2()       // optional: enable if you want to guard against bad data instead of letting client cope with it
akauppi commented 3 years ago

Sam Stern mentioned at https://github.com/firebase/firebase-tools/issues/3258

Right now neither fix has been released but when the next JS SDK and Emulator release go out either fix should be sufficient to stop this issue from happening.

i.e. Firestore Emulator 1.11.15 should suffice

akauppi commented 3 years ago

done