4 small changes - Githubissues

akavel / ditaa

Go port/fork of ditaa. ditaa is a small command-line utility that can convert diagrams drawn using ascii art ('drawings' that contain characters that resemble lines like | / - ), into proper bitmap graphics.

GNU General Public License v2.0

54 stars 5 forks source link

4 small changes #4

Closed splitbrain closed 8 years ago

splitbrain commented 8 years ago

This PR contains 4 commits to:

fix #3
make the code simpler to work with in a fork
clean up some formatting
add a build script to create various binaries (related to #2)

I'm not a go developer so any of this might be wrong, even though it works for me (compiles and runs). Feel free to cherry pick single commits if you don't want them all.

akavel commented 8 years ago

Thanks!

I'll try to merge soon™... not sure if I'll have time this week, hopefully the next one at the farthest...

by the way, I'll probably update the license: I forked from a last commit of a GPLv2 version, but then the next commit in the original repo switched to GPLv3 or LGPLv3; I'll try to update the licensing here to allow for both ones; can I assume you'd be OK with your contribution being dual-licensed this way?

splitbrain commented 8 years ago

"GPL2 or later" would be most helpful for where I want to use this. But dual licensing would work too.

GPL3 might work for me too depending on how to interpret "linking" - I will call it from GPLv2 software.

splitbrain commented 8 years ago

closing this in favor of #5 and #6

akavel commented 8 years ago

Out of curiosity: from what software are you planning to call it?

splitbrain commented 8 years ago

DokuWiki ditaa plugin - easier for some to run a single binary than getting a Java VM to their server.

akavel commented 8 years ago

Cool, thanks for info! Hope Stathis won't get mad... but it's really all his glory and brainchild still, only in different lingo.