search

akavel / rsrc

Tool for embedding .ico & manifest resources in Go programs for Windows.
MIT License
1.22k stars 122 forks source link

Adding support for version info #14

Open josephspurrier opened 8 years ago

josephspurrier commented 8 years ago

This addresses: https://github.com/akavel/rsrc/issues/10

akavel commented 8 years ago

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

README.txt, line 7 [r1] (raw file): What's the format of the expected contents of the versioninfo.json file? A well-written description (usage info) for end-user must be available in the help message below.

_rsrc.go, line 17 [r1] (raw file):_ Just to make it clear, if we get this merged, I'd be planning to have it vendored in future, and at some point potentially refactored to be more along with my vision of how to organize code in this project (obviously keeping all copyrights I find in process).

_rsrc.go, line 215 [r1] (raw file):_ Please remove the commented-out logging lines (here and below).

Comments from the review on Reviewable.io

akavel commented 8 years ago

(Please note I'm ok if you respond straight on github, not via "Reviewable"; I'm just testing that service, not even sure if I'll stick with it or not.)

reedlaw commented 5 years ago

I couldn't get this PR working so I "fixed" it for my own use, which might help others in the same situation: https://github.com/Doctible/rsrc

Sorry I don't have time to address the code review issues above. There were some import changes in this PR that don't work without merging so I made my version reference its own packages.

Also, the versioninfo didn't work unless the id is 1 (referenced by a goversioninfo build), so it's hard-coded.