search

akavel / up

Ultimate Plumber is a tool for writing Linux pipes with instant live preview
Apache License 2.0
8.39k stars 129 forks source link

keys: Implement unix-word-rubout (Ctrl-W) #54

Closed padawin closed 3 years ago

padawin commented 3 years ago

unix-word-rubout erases all the characters before the cursor until finding either a space or a BOL.

fixes #53

padawin commented 3 years ago

I am about to push a fixup commit tackling the above. Once approved, I'll rebase and bring the commits together.

akavel commented 3 years ago

(As a very side-note, just in a feeble attempt at stirring your interest enough to maybe implement some tiny itch for a future idea, I'm not sure if you've seen the concept for maybe delegating stuff to some thirdparty readline reenactment package. I'm personally finding it very interesting, though what holds me personally back from working on it, is that as a maintainer, I should really try again to untangle #42 first... But as I say, that's just a very side note, we're all trying to have fun here, so I appreciate your finding a way to do that by helping up already with this PR 🙂 )

padawin commented 3 years ago

Regarding your side note, it does indeed sound quite interesting. I could see to have a look deeper, in case there is anything I could do to contribute around there :-)

akavel commented 3 years ago

Heyy @padawin ! Not hurrying or whatever, just to make sure we didn't miss something - I noticed you replied, however I don't seem to see any new commits yet; to make it clear, that's completely fine with me, and it's more than sensible that on Easter we focus on other things :) The only reason really I'm writing anything, is that I had enough cases in my career of people (myself included) forgetting to push the commit to a PR; and I really wouldn't want such a dumb accident in any case be the sole reason why this feature didn't get merged :) so, as I'm trying to say, absolutely no pressure or whatever (I'd be the last person to have right to put it), please treat it just as a friendly heads up :)

padawin commented 3 years ago

Hey @akavel, Thanks for following up! I didn't work on it due to Easter. I just attended the comments now and pushed them :-)

padawin commented 3 years ago

I do not have the permissions to merge in your master @akavel , so I squashed my fixup commits, and you can merge the branch in master now. :rocket:

padawin commented 3 years ago

@akavel could you merge this PR when you have a moment?

akavel commented 3 years ago

@padawin Uhh, HUGE thanks for reminding me, I was off the grid for some holidays and this fell through the cracks. Really sorry and again REALLY BIG thanks for your patience and persistence ❤️ ❤️ ❤️