akazadd / NimbleTechTest

This repository contains the iOS technical test project for Nimble - a demonstration of skills in iOS development for the technical evaluation process.
0 stars 0 forks source link

[Feature] Pagination support #21

Closed minhnimble closed 11 months ago

minhnimble commented 11 months ago

Issue

As you can probably see from the Postman, the Surveys List API should be capable of providing more data than what the application currently displays. Currently, the data shown on the Surveys List screen is only fixed to a page of 5 items. As a result, there is no way for the user to see all the data available from the API response.

https://github.com/akazadd/NimbleTechTest/blob/e6c67511d586c9707b45295fd5591ffb1b57a474/NimbleTechTest/Home/HomeViewController.swift#L43

Expect

The application could paginate to load all the survey list data by using some user inputs (swipe to the last survey item to trigger the load more action, add the load next page button, etc.).

akazadd commented 11 months ago

Hello Mike,

Thank you for pointing out the limitation in the current Surveys List API implementation. I understand the requirement, and I will work on enhancing the functionality to allow users to paginate and load all survey data based on your suggestions.

I'll explore options such as implementing infinite scrolling (where new data is loaded as the user scrolls to the end of the list), adding a "Load More" button, or incorporating swipe-to-load functionality. I will carefully evaluate these options and choose the one that best fits the user experience and the application's design.

I'll keep you updated on my progress and let you know once the enhancements are implemented. If you have any specific preferences or additional suggestions regarding the implementation, please feel free to share them.

Thank you for your guidance, and I'm committed to making the necessary improvements to meet the expectations.

Regards, Mohammad Abul Kalam Azad

On Thu, Nov 9, 2023 at 2:48 PM Pham Le Minh @.***> wrote:

Issue

As you can probably see from the Postman, the Surveys List API should be capable of providing more data than what the application currently displays. Currently, the data shown on the Surveys List screen is only fixed to a page of 5 items. As a result, there is no way for the user to see all the data available from the API response.

https://github.com/akazadd/NimbleTechTest/blob/e6c67511d586c9707b45295fd5591ffb1b57a474/NimbleTechTest/Home/HomeViewController.swift#L43 Expect

The application could paginate to load all the survey list data by using some user inputs (swipe to the last survey item to trigger the load more action, add the load next page button, etc.).

— Reply to this email directly, view it on GitHub https://github.com/akazadd/NimbleTechTest/issues/21, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZTMOCWOEO75K4NOHBIMS3YDSKGFAVCNFSM6AAAAAA7EFWNAKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DKMJSGI3DQOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

akazadd commented 11 months ago

Pull Request -> https://github.com/akazadd/NimbleTechTest/pull/35