Wrap configs in Result[]

[akazukin5151]

Compare to using or in the use-or branch

https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/lscat.py#L39

https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/utils.py#L183

Advantages of using Result

• Functions in utils.py very clean https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/utils.py#L170-L176 https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/utils.py#L178-L180 https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/utils.py#L182-L185
• Spacing can be immediately assigned to https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/lscat.py#L102-L104
  • (Old version for comparison): https://github.com/twenty5151/koneko/blob/3dc728f89090ab046f690129fcd6a9053955f3ea/koneko/lscat.py#L100-L104
  • (Using or; for comparison. Using or looks good too) https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/lscat.py#L88-L90

Disadvantages of using Result

• lscat functions not so clean https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/lscat.py#L50-L58 https://github.com/twenty5151/koneko/blob/c80fbb50338981f73be3a6e0e851cb13e80ed3fe/koneko/lscat.py#L78-L85
• Need to fix tests

Advantages of use-or

• More pythonic
• One less external dependency

Disadvantages of use-or

• Ugly try-catch still exists https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/utils.py#L187-L190
• Still need to early return missing path https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/utils.py#L171-L173 https://github.com/twenty5151/koneko/blob/3945099119f2c85b7729a4ef2c726621e0d15ba0/koneko/utils.py#L180-L182

[akazukin5151]

Using or doesn't even catch any exception being raised. Railway will be accepted.