akcdotorg / akc.org

0 stars 0 forks source link

/dog-breeds/[breedname]/pictures/ page #163

Closed stevepessah closed 8 years ago

stevepessah commented 8 years ago

This is related to #135

We would like to include the following on this page:

kylejbertelsen commented 8 years ago

See toggle on #135. If set to UGC, redirect back to breed page at pictures anchor.

toshan2014 commented 8 years ago

New page "/pictures" created. Example : http://develop2.akc.org/dog-breeds/affenpinscher/pictures/ This page has the following:

Please QA : http://develop2.akc.org/dog-breeds/affenpinscher/pictures/

toshan2014 commented 8 years ago

Time spent: 7h ( two things took longer than expected - 1. ads were not showing 2. this page is special as it lies underneath listing channel pages in Structure and it was initially impossible to create as there was no documentation of how to make such a page ) . Here's the doc I've created in case such new pages have to be built : https://akcorg.atlassian.net/wiki/display/BEV/Allow+the+creation+of+pages+underneath+listing+channel+pages+in+Structure

spaulenoff commented 8 years ago

@toshan2014 Some Notes: When going to each slide, the URL change like so - http://develop2.akc.org/dog-breeds/affenpinscher/pictures/?photo_id=0, http://develop2.akc.org/dog-breeds/affenpinscher/pictures/?photo_id=1, http://develop2.akc.org/dog-breeds/affenpinscher/pictures/?photo_id=2.

This causes the title tag to disappear. can we make so ever slide as well as the ad and end car all have the same title tag and metadata as http://develop2.akc.org/dog-breeds/affenpinscher/pictures/ image

toshan2014 commented 8 years ago

@spaulenoff please check again.

spaulenoff commented 8 years ago

@stevepessah I checked and I am seeing it outlined as above. Please Qa on dev2: http://develop2.akc.org/dog-breeds/beagle/pictures http://develop2.akc.org/dog-breeds/affenpinscher/pictures

stevepessah commented 8 years ago

@spaulenoff same note about the URL as in #135. Also:

spaulenoff commented 8 years ago

@toshan2014 Please make the changes outlined above and please confirm if first question is possible

toshan2014 commented 8 years ago

@spaulenoff changes made - please check http://develop2.akc.org/dog-breeds/affenpinscher/pictures/

toshan2014 commented 8 years ago

Time spent : +15min

spaulenoff commented 8 years ago

Verified on Dev2

toshan2014 commented 8 years ago

Stage: http://stage-ng.akc.org/dog-breeds/affenpinscher/pictures/

toshan2014 commented 8 years ago

pf : http://develop2.akc.org/dog-breeds/beagle/pictures/

toshan2014 commented 8 years ago

Time spent : +1.5h (social aggregator fix)

spaulenoff commented 8 years ago

verified on prod