akcdotorg / akc.org

0 stars 0 forks source link

Implement new top banner for Sign Up, Login, Search #198

Closed stevepessah closed 8 years ago

stevepessah commented 8 years ago

Mockup below includes the following requirements:

new top nav

spaulenoff commented 8 years ago

Assign to Shailesh once description is added

skt2 commented 8 years ago

Time Spent: 7h(20th Apr) Time Spent: 1h(21st Apr) Time Spent: 1h(22nd Apr)

@kylejbertelsen: do we want this in a way so that is available in common header wrapper as well or just for akc.org site?

skt2 commented 8 years ago

@stevepessah: can you please confirm that this changes are only for desktop, we don't want to show top nav on mobile?

skt2 commented 8 years ago

@stevepessah @spaulenoff: do we want to implement this on /learn page as well? It's different header and might take more time so if want to get rid of /learn in near future then better not to waste time in this.

skt2 commented 8 years ago

New top grey banner that needs to go on all AKC.org pages (including apps, so this will need to be coordinated). -- Can you please explain "including apps"?

stevepessah commented 8 years ago

@skt2 this is something that needs to be coordinated with ISD that @spaulenoff can manage.

We're also phasing out the current /learn section so we don't need to place it on there.

spaulenoff commented 8 years ago

Just sent email to ISD. included @skt2 @stevepessah and @kylejbertelsen

spaulenoff commented 8 years ago

@skt2 Seeing all things except for the shop tab in the navigation. @stevepessah Can you please provide the URL that the Shop Tab should link to? or will this just be added via the CMS?

stevepessah commented 8 years ago

@spaulenoff the link will be added to the CMS once we have the proper URL. We should still be able to add the tab there with a link placeholder.

spaulenoff commented 8 years ago

@skt2 Please make sure Mobile doesn't change from what is currently on production. Otherwise, desktop functionality looks good.

spaulenoff commented 8 years ago

the URL will be akc.org/akc-store/

aalattili commented 8 years ago

@spaulenoff, In Mobile web, sign in banner in develop2 is different than what's in prod site. (Mobile web-Sign in banner.png). Tested on iPhone 6 plus & Samsung Tablet.

mobile web-sign in banner

spaulenoff commented 8 years ago

@skt2 Please make the change @aalattili outlined above

aalattili commented 8 years ago

QA passed in develop2.

aalattili commented 8 years ago

Stage-ng, Mobile web. 1- Sign in banner is displaying as what's in desktop browsers 2- background isn't white stage-sign in banner

skt2 commented 8 years ago

@aalattili on which device you tested this?

aalattili commented 8 years ago

@skt2 on both iPhone 6 plus & Samsung tablet

skt2 commented 8 years ago

@aalattili I pushed fixed for this. you can test on dev2 and stage.

aalattili commented 8 years ago

@skt2, QA retesting passed on both dev2 & stage

spaulenoff commented 8 years ago

Verified on Prod