akcdotorg / akc.org

0 stars 0 forks source link

Breed care and detail pages should use breed hero image when shared #32

Closed stevepessah closed 8 years ago

stevepessah commented 8 years ago

When sharing one of the /detail or /care links, it uses the standard AKC dog image instead of the breed image.

og:image, and other meta tags should be using the hero image URL

skt2 commented 8 years ago

Tested here: http://develop2.akc.org/dog-breeds/airedale-terrier/detail/ http://develop2.akc.org/dog-breeds/airedale-terrier/care/ @spaulenoff if any of the other page didn't work for you then please go to: https://developers.facebook.com/tools/debug/ -- paste that url and click debug and try again.

skt2 commented 8 years ago

Time spent: 3h

skt2 commented 8 years ago

Tested here: http://stage-ng.akc.org/dog-breeds/american-hairless-terrier/detail/ http://stage-ng.akc.org/dog-breeds/american-hairless-terrier/care/

aalattili commented 8 years ago

QA retesting Failed on dev2 & stage as folowing, (Note that these issues are applicable on both environments) Tested on browsers (GC 50, FF 45 & IE 11): 1- Sometimes image takes long time to load 2- For some pages, Image is missing. ex: http://develop2.akc.org/dog-breeds/alaskan-malamute/detail/ (Shared link-Missing dog breed hero image.jpg) shared link-missing dog breed hero image 3- For Some page unclear Image is displaying. ex: http://stage-ng.akc.org/dog-breeds/affenpinscher/detail/ (Shared link-Un clear image.jpg) shared link-un clear image 4- For Some pages, image for breed not related to the shared link is displaying. ex: http://develop2.akc.org/dog-breeds/airedale-terrier/detail/ (Shared link-Not hero image is displaying.jpg) shared link-not hero image is displaying

skt2 commented 8 years ago

Tested here: http://www.akc.org/dog-breeds/airedale-terrier/detail/ http://www.akc.org/dog-breeds/airedale-terrier/care/ Note: if any of the other page didn't work for you then please go to: https://developers.facebook.com/tools/debug/ -- paste that url and click debug and try again. @aalattili @spaulenoff

spaulenoff commented 8 years ago

Verified on Prod