akcuster / plantParentHelper

Helps new plant parents manage the various needs of their house plants
0 stars 0 forks source link

Week 6 Review #2

Closed Kharsla closed 2 years ago

Kharsla commented 3 years ago

Design/Code Review 1

Project: Plant Parent Helper

Developer: Amber Custer

Reviewer: Kaitlyn Harsla

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. EVERY item should have at least one "kudos" and one suggestion for improvement
Problem Statement 1. Accurately describes the project's purpose.
2. Is professional and free of typos, slang, etc.
3. Thoroughly explains the problem and the solution.
4. Is understandable by the average person.
Great problem statement. Describes the problem very well and in a fun way. A bit more detail could be added to explain how the application will work.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens.
5. Project plan and time log are up-to-date.
Your user stories are detailed. Your home page wireframe looks professional and is very well done. There isn’t any documentation or visuals to understand or review the flow of your project.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model.
2. There are at least two 1-to-many relationships.
3. The model represents good database design.
There is no data model or database design to comment on.
Code 1. Proper Maven project structure is used.
2. a .gitignore file for IntelliJ Java projects has been implemented.
3. There is not any redundant or copy/paste code in the JSPs or classes.
4. Classes are appropriately-sized (no monster classes).
Property files are used appropriately: no hard-coded values.
5. Logging statements are used rather than System.out.println and printStackTrace (be sure to use a search to look for these!).
6. There are appropriate unit tests/code coverage.
There is no code for me to review at this time. There is the index.jsp but nothing has been added to it yet. The log4j properties file looks good. There is a .gitignore file.

​ ​ ​