search

akdess / CaSpER

77 stars 28 forks source link

plotHeatmap() saves the plot in the working directory and not at the specified path #46

Closed ftucos closed 3 years ago

ftucos commented 3 years ago

plotHeatmap() function was ignoring the file name parameter and exporting everything in the working directory as "heatmap.png". I sent you a pull request fixing this bug

mmfalco commented 3 years ago

In plotHeatmap10x() function, also doesn't take into account some other arguments such as show_rownames. It should be great if some color sidebar could be added in the plot to add additional annotations.

cstubben commented 3 years ago

Both plotHeatmap and plotHeatmap10x fail to pass options like fileName, show_rownames, cluster_cols, cluster_rows to the pheatmap function (and maybe add dots ... for additional arguments).

akdess commented 3 years ago

Thanks a lot @ftucos, @mmfalco and @cstubben for reporting this issue!