akdukaan
commented
1 year ago On top of that it can't possibly be too hard to just cancel the "Make Map" event
I looked into this and there is no MakeMapEvent. I’d have to cancel the PlayerInteractEvent which complicates things quite a lot. I’d have to do a lot of filtering to see if this event was an attempt to create a map or something totally unrelated like open a chest.
And even after doing all that filtering, just canceling the event if the player is standing within the claim could easily be bypassed. I don’t know all that much about how map creation works, so correct me if I’m wrong here. But if someone stands just outside of the claim, they’d still be able to render the art within the claim, or at least part of it.
The only way I could see this being feasibly implemented would be after some sort of MapCreateEvent is made by some Bukkit implementation. This would also let me more easily look at the area contained by the map and appropriately cancel only the maps that should be canceled.
And with a MapCreateEvent, I imagine I would have much more control of the map that is created. However, I could see the flag causing issues if, for instance, someone wants to make a map of their own claim but there’s a nearby claim with the NoMapMaking flag. I considered simply cutting the claim out of the map and have the map rendered with a hole in it which makes more sense than canceling the map entirely. However, doing that, I’d still have to consider how players might try to update the map. I can lock the map to make it not further discoverable but that means that they also wouldn’t be able to continue to discover more of the map outside of the claim. Unfortunately, there doesn’t seem to be a good way to cut a hole in a map.
So in summary, I don’t think this flag is something I can really consider adding until a MapCreateEvent is made, and even then, there are a lot more details I’d need to consider.
Phoenix616
ZepsiZola
Is your feature request related to a problem? Please describe. Players on my SMP server get annoyed when they work so hard on creating a map-art that they intend on selling, only for other players to stumble across it and make their own maps from it, causing their map-arts to become essentially worthless. The issue stems from people being able to create unauthorized map-arts in someone else's claim.
Describe the solution you'd like I just want a simple flag that stops people who aren't authorized in the claim from making maps in it. Something like "NoMapMaking" would make sense. On top of that it can't possibly be too hard to just cancel the "Make Map" event or whatever.
Describe alternatives you've considered I've told the players that they can also cover their maparts if they dont want them stolen, but apparently that's too much hassle.