search

akdukaan / GPFlags

GriefPreventionFlags is a Minecraft plugin to allow players to customize their GriefPrevention claims with claimflags.
GNU General Public License v3.0
17 stars 20 forks source link

NoMonsters Trial Chamber Config Option #75

Closed wyattduber closed 4 weeks ago

wyattduber commented 4 weeks ago

Hello,

I am writing to see if it is possible to add a config option to allow/disable the effects of the NoMonsters flag when it comes to Trial Chambers.

We've been running into instances of players on our server being able to claim trial chambers, add the NoMonsters flag, and then claim free loot. This isn't an issue with the plugin necessarily, as it is functioning as it should. We've had to disable use of the NoMonsters flag to prevent this as we just reset our map for the 1.21 major version update and don't want players getting free loot this early into the map.

Our players love using this flag for their personal claims, so we would like to avoid having to disable this entirely. I am not sure if this is possible from a developer perspective so please provide some insight to if this is possible.

Thanks! Wcash

akdukaan commented 4 weeks ago

Mobs in trial chambers come from spawners, right? Have you considered using the config option to make NoMonsters not affect spawner mobs

IAISI commented 4 weeks ago

That's based on spawn reason? Trial spawners have own SpawnReason https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/entity/CreatureSpawnEvent.SpawnReason.html#TRIAL_SPAWNER

akdukaan commented 4 weeks ago

That's based on spawn reason? Trial spawners have own SpawnReason https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/entity/CreatureSpawnEvent.SpawnReason.html#TRIAL_SPAWNER

Ooh thanks for this info! I guess the config option doesn’t affect trial spawners in any way at the moment. I’ll get the config option to work with trial spanwers today. When that’s done, is that going to be enough to resolve this @wyattduber ?

wyattduber commented 4 weeks ago

Yes, I think so! Thank you so much for your quick reply!!

wyattduber commented 2 weeks ago

@akdukaan Hello, sorry to bother but this change has yet to be released to my knowledge. Any idea on when this change will be released? Just curious!

akdukaan commented 2 weeks ago

@akdukaan Hello, sorry to bother but this change has yet to be released to my knowledge. Any idea on when this change will be released? Just curious!

You can download from https://jenkins.luminescent.dev/job/GPFlags/

wyattduber commented 2 weeks ago

Thanks! I will try this.