search

akeeba / engage

Akeeba Engage - Comments for Joomla!™ articles made easy
GNU General Public License v3.0
16 stars 10 forks source link

Update CommentsController.php #198

Closed colivier closed 2 years ago

colivier commented 2 years ago

The id field is ambiguous in the sort because the SQL query on the #__engage_comments table has joins on the #content and #categories tables (see the getListQuery method of the administrator/components/com_engage/src/Model/CommentsModel.php file).

This ambiguity does not create a issue, it is just a little improvement

nikosdion commented 2 years ago

We don't have any other ID column in the select in \Akeeba\Component\Engage\Administrator\Model\CommentsModel::getListQuery therefore there is no ambiguity.

Changing the default ordering in \Akeeba\Component\Engage\Site\Controller\CommentsController would require changing the HHMVC code in \Joomla\Plugin\Content\Engage\Extension\Engage::renderComments. Maybe other changes elsewhere. Why spend so much time verifying that a change doesn't break anything when the change does not address any existing issue?