search

akeeba / engage

Akeeba Engage - Comments for Joomla!™ articles made easy
GNU General Public License v3.0
16 stars 10 forks source link

Ip filter does not work on back-end #267

Closed NicolasDerumigny closed 1 year ago

NicolasDerumigny commented 1 year ago

Please read the README.md in the repository's root and the support resources before submitting an issue.

Steps to reproduce the issue

Go in the back-end and try to fliter the results by ip.

Expected result

One the comments with the filtered ip are displayed.

Actual result

All comments are displayed.

Troubleshooting already performed

development/component/backend/src/Model/CommentsModel.php line 46 should be set to ParameterType::STRING. Also, $fltSearch is not filled properly by the back-end link, preventing the patch to work either way.

System information

Linux 5.15.84 on a Raspberry Pi 3B running Debian 11

Mandatory information

Issues without this information can not and will not be replied to.

Good to have information

You can skip some or all of this information. However, the more information you provide the faster and better we can help.

Additional comments

It would also be nice to have the same button with user id filtering / mail adress.

nikosdion commented 1 year ago

Thank you for the heads up. I fixed it.

It would also be nice to have the same button with user id filtering / mail adress.

Use the Search box. It support different prefixes, please read https://github.com/akeeba/engage/wiki/Comment-administration#filters

NicolasDerumigny commented 1 year ago

I have read it, but I was asking for a dedicated button as, for example, ip:192.168.1.1 is not a valid query due to the last space. Thanks for the correction!