search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Fields rowid #571

Closed Eighke closed 8 years ago

Eighke commented 8 years ago

I found a small problem, in the Fields $rowid is supposed to be "A monotonically increasing number", but currently it is the field's database id.

It has no impact on current Fields The problem is only if we want to implement some new Field and use it as it should be.

It is easily fixable, but I'm not sure if you want to keep the current behaviour instead?

Eighke commented 8 years ago

Oh, in final it is a real bug, it breaks the Ordering field when using the input instead of the drag & drop.

nikosdion commented 8 years ago

I just pushed a commit to fix it. Can you please verify?

Eighke commented 8 years ago

Nope it looks like the first row has to be 0, not 1. I fixed it + a small change in the toolbar.

nikosdion commented 8 years ago

Thank you!