search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Make it possible for the CSV to access relations. Fixes #541 #573

Closed wilsonge closed 8 years ago

wilsonge commented 8 years ago

I need to test the modifications I made work before you merge this :P

nikosdion commented 8 years ago

I am not merging until you ping me and tell me that everything tests out all right.

Even better, can you write a Unit Test? :)

wilsonge commented 8 years ago

OK it tests out ok (I haven't done anything too detailed - just ensured that using CSV Fields with a mixture of relation based fields and fields from the view).

I'll try and write a unit test. But for the CSV output I think it's going to be a nightmare trying to mock this all up - especially because it's all in the display method so I'm going to have to mock up things like the headers being set I guess (and so far we only have unit tests for the raw output - so it's not like there's anything to work with). But I'll see how things go.

nikosdion commented 8 years ago

OK, I'm merging this PR. When you get to the unit test just file a new PR :)