akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

TreeModel.php #583

Closed willfaulds closed 8 years ago

willfaulds commented 8 years ago

updated a number of incorrect code comments (often referring to lft when code uses rgt etc.)

also where applicable change var from myLeft/myRight to insertLeft/insertRight as more appropriate naming (≠ node's lft or rgt but == sibling's/parent's lft or rgt).

nikosdion commented 8 years ago

I'd rather not change variable names – not until I have the time to make the tests work properly again.

willfaulds commented 8 years ago

I'd offer to do that too but haven't a clue about it - nothing that effects working process/results here so put on ice for now?

willfaulds commented 8 years ago

Sorry didn't mean to add more commit - I'm still getting my head around github - new branch for every commit...