Drag and drop ordering doesn't work in a fof/J!3 component

[peterpeter]

Hi I got two older fof-extensions running on client sites, done with the joomla-shipped version of fof. If I enable ordering in a list-view, drag and drop ordering works not, since the ordering input fields have to be hidden (display="none") (marked in the screenshot). And thus makes the saving button above pretty useless too.

If I'm hiding the inputs, the DnD/Ajax-Ordering works and the look of these views is identical to the rest of the other list views. But since the fof libary get updates I have to repeat this modifications (two times).

And now I want to go the only way that is right and make sense by doing a PR for that :P

So question: Any chance for that PR to get accepted? And where? In this repository or at the Joomla repo?

[nikosdion]

Hello Peter,

Since it's FOF 2 which is no longer maintained by us I'd recommend making the PR to Joomla and at-metnion me (@nikosdion) so I can review it. Do link to this thread in your PR so the PLT knows that I have explicitly asked you to submit changes to Joomla! directly instead of upstream (FOF 2) because FOF 2 is end of life.

Best regards,

Nicholas K. Dionysopoulos Director, Akeeba Ltd https://www.AkeebaBackup.com https://www.akeebabackup.com/

On 12 Aug 2016, at 08:30 , peterpeter notifications@github.com wrote:

Hi I got two older fof-extensions running on client sites, done with the joomla-shipped version of fof. If I enable ordering in a list-view, drag and drop ordering works not, since the ordering input fields have to be hidden (display="none") (marked in the screenshot). And thus makes the saving button above pretty useless too.

If I'm hiding the inputs, the DnD/Ajax-Ordering works and the look of these views is identical to the rest of the other list views. But since the fof libary get updates I have to repeat this modifications (two times).

And now I want to go the only way that is right and make sense by doing a PR for that :P

So question: Any chance for that PR to get accepted? And where? In this repository or at the Joomla repo?

https://cloud.githubusercontent.com/assets/485313/17622025/1839ec5e-6098-11e6-8b6c-2173d8170986.jpg — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/issues/625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPoKZchR9DdoqFHvUsJhg9Ibkd9N5UNks5qfGdOgaJpZM4JjCe7.

[nikosdion]

Actually, do NOT modify FOF. The problem lies in Joomla! itself. Their Javascript is using the wrong selectors to find the order field. I will submit a PR to fix the real issue instead of breaking all components running on FOF.

Nicholas K. Dionysopoulos Director, Akeeba Ltd https://www.AkeebaBackup.com https://www.akeebabackup.com/

On 12 Aug 2016, at 08:30 , peterpeter notifications@github.com wrote:

Hi I got two older fof-extensions running on client sites, done with the joomla-shipped version of fof. If I enable ordering in a list-view, drag and drop ordering works not, since the ordering input fields have to be hidden (display="none") (marked in the screenshot). And thus makes the saving button above pretty useless too.

If I'm hiding the inputs, the DnD/Ajax-Ordering works and the look of these views is identical to the rest of the other list views. But since the fof libary get updates I have to repeat this modifications (two times).

And now I want to go the only way that is right and make sense by doing a PR for that :P

So question: Any chance for that PR to get accepted? And where? In this repository or at the Joomla repo?

https://cloud.githubusercontent.com/assets/485313/17622025/1839ec5e-6098-11e6-8b6c-2173d8170986.jpg — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/issues/625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPoKZchR9DdoqFHvUsJhg9Ibkd9N5UNks5qfGdOgaJpZM4JjCe7.

[nikosdion]

As promised https://github.com/joomla/joomla-cms/pull/11571 https://github.com/joomla/joomla-cms/pull/11571

Please test this PR and submit your test results to the Joomla! issue tracker. The faster we get this fixed the better it will be for all of us.

Best regards,

Nicholas K. Dionysopoulos Director, Akeeba Ltd https://www.AkeebaBackup.com https://www.akeebabackup.com/

On 12 Aug 2016, at 11:44 , Nikolaos Dionysopoulos nicholas@akeebabackup.com wrote:

Actually, do NOT modify FOF. The problem lies in Joomla! itself. Their Javascript is using the wrong selectors to find the order field. I will submit a PR to fix the real issue instead of breaking all components running on FOF.

Nicholas K. Dionysopoulos Director, Akeeba Ltd https://www.AkeebaBackup.com https://www.akeebabackup.com/

On 12 Aug 2016, at 08:30 , peterpeter <notifications@github.com mailto:notifications@github.com> wrote:

Hi I got two older fof-extensions running on client sites, done with the joomla-shipped version of fof. If I enable ordering in a list-view, drag and drop ordering works not, since the ordering input fields have to be hidden (display="none") (marked in the screenshot). And thus makes the saving button above pretty useless too.

If I'm hiding the inputs, the DnD/Ajax-Ordering works and the look of these views is identical to the rest of the other list views. But since the fof libary get updates I have to repeat this modifications (two times).

And now I want to go the only way that is right and make sense by doing a PR for that :P

So question: Any chance for that PR to get accepted? And where? In this repository or at the Joomla repo?

https://cloud.githubusercontent.com/assets/485313/17622025/1839ec5e-6098-11e6-8b6c-2173d8170986.jpg — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/issues/625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPoKZchR9DdoqFHvUsJhg9Ibkd9N5UNks5qfGdOgaJpZM4JjCe7.

[peterpeter]

Hi Nic I wanted to test the fix. It seems to be fixed, tested and merged. Thank you for your work to fix this issue. And by the way thank you for your huge effort in general ;-)

Kind regards