Closed rameshelamathi closed 7 years ago
I'd prefer if you'd write it as if (!empty($this->layout))
instead. The !$this->layout
idiom is fairly ambiguous. I am trying to keep new code clean from this kind of code smell :)
When you update the PR please write a comment, otherwise GitHub may never notify me.
Done. Ambiguous code corrected. Updated the PR. Thanks Nick
Oops, sorry, I kept an exclamation mark too many in my reply :/ It should be if(empty(
, not if(!empty(
. Sorry!
@rameshelamathi can you make the correction to if(empty(
?
Sorry for the delay... Correction is done :-)
Thank you!
Reference: add() method It has the layout check done correct.