search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Editing produces a layout not found error #629

Closed rameshelamathi closed 7 years ago

rameshelamathi commented 8 years ago

Reference: add() method It has the layout check done correct.

nikosdion commented 8 years ago

I'd prefer if you'd write it as if (!empty($this->layout)) instead. The !$this->layout idiom is fairly ambiguous. I am trying to keep new code clean from this kind of code smell :)

When you update the PR please write a comment, otherwise GitHub may never notify me.

rameshelamathi commented 8 years ago

Done. Ambiguous code corrected. Updated the PR. Thanks Nick

nikosdion commented 8 years ago

Oops, sorry, I kept an exclamation mark too many in my reply :/ It should be if(empty(, not if(!empty(. Sorry!

photodude commented 7 years ago

@rameshelamathi can you make the correction to if(empty( ?

rameshelamathi commented 7 years ago

Sorry for the delay... Correction is done :-)

nikosdion commented 7 years ago

Thank you!