search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

PHP Best practices and some optimizations + cleanup #632

Closed frankmayer closed 7 years ago

frankmayer commented 7 years ago

Hello Nick, here are some low-hanging fruits I picked for optimizing and cleaning up a bit. I hope they are of use to you. Feel free to accept any or all of those.

(Initially I had multiple commits, that were easier to digest, but somehow I messed up with git, and had made the changes based on the 2.0 branch, so there were a lot of previous commits in conflict. I hope this big commit is OK for you.)

nikosdion commented 7 years ago

I cannot possibly accept a PR with an unclear description, unclear scope and which touches several hundred lines on every single file. The amount of time to just verify that no bugs were introduced is not worth the effort.