Test against HHVM current and PHP 7.1

photodude commented 7 years ago

add PHP 7.1 to tests
fix HHVM to run on current (3.15.x as of this PR ) rather than the HHVM 3.6.6 version Travis CI precise container is permanently stuck on.
switch to git clone the joomla branches to test against since the git submodules do not stay current with joomla automatically, the git submodules are left for local testing.

nikosdion commented 7 years ago

Actually, FOF is compatible with PHP 5.3 and 5.4. A typo in 3.0.13 broke compatibility with PHP 5.3 and 5.4. That was fixed in 3.0.14. That's why the change was marked as extremely important (!) in the changelog.

Further to that, FOF is actually tested against Joomla's current version which, at the time of this writing, is 3.6. We do NOT target the next version (3.7) until the first beta is released.

Finally, Joomla! 4.x may or may not be what you have in the 3.5-dev branch of the Joomla repository and we may or may not support it. Adding a test target against it is premature, to say the least.

photodude commented 7 years ago

I have restored the PHP 5.3 and PHP 5.4 testing.

There is something wrong with the current FOF testing on travis that tells me it's not testing against Joomla's current version. the 3.5-dev tests have the following error PHP Fatal error: Cannot use Joomla\String\String as String because 'String' is a special class name in /home/travis/build/akeeba/fof/Tests/environments/3.5-dev/libraries/vendor/joomla/registry/src/Format/Json.php on line 12 that's why I switched to git clone to pull staging for travis. I left the git submodules since those are used in local testing and travis can have a totally different set up.

Let me know if there are other adjustments needed and I'll make those changes.

akeeba / fof

Test against HHVM current and PHP 7.1 #633