search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Use getMockBuilder rather than getMock directly #639

Closed photodude closed 7 years ago

photodude commented 7 years ago

Use getMockBuilder rather than getMock directly to Avoid situations that would cause PHP Fatal error: Call to protected method FOF30\Tests\Form\Field\CalendarTest::getMock() on newer versions of phpunit

@nikosdion would you like these fixes as a bunch of small PR's or shall I fix all of them in this PR? (I think there are about 66 files needing this change)

photodude commented 7 years ago

@nikosdion would you like these getMockBuilder fixes as a bunch of small PR's or shall I fix all of them in one PR?

nikosdion commented 7 years ago

Since it's conceptually the same fix (replace getMock with getMockBuilder) I'd rather have it as one big PR. When the PR is ready use the Reviewers area to assign me as a reviewer. This sends me an email asking for a code review. In case there are changes needed it lets me more easily point out what needs to be changed or, if everything is file, mark it as ready for merge. That's a new GitHub feature which is excellent for situations like this :)