akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Use getMockBuilder rather than getMock directly #640

Closed photodude closed 7 years ago

photodude commented 7 years ago

Continues the Unit Test improvement work done in #639

photodude commented 7 years ago

@nikosdion I have completed the conversion of getMock() to implement getMockBuilder(). As just a contributor I apparently am not able use the Reviewers area to assign you as a reviewer.

I have noticed that there are some new test errors and failures with some of the tests. I've looked through the changes and a few other things but have so far been unable to determine why some tests now have "Trying to get property of non-object" errors.

nikosdion commented 7 years ago

Sorry for the really long time. Things happened and I didn't have the time to go through this PR. I have merged it and will keep working on the errors in the tests.

photodude commented 7 years ago

Thanks for the merge, glad to help