search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Added possibility to create a dedicated Form class for the Form object #645

Closed Skullbock closed 7 years ago

Skullbock commented 7 years ago

@nikosdion found myself in a situation where this could be useful (i needed to change some form to model binding stuff) so i discovered that it wasn't possible as it is for the Toolbar class.

I tested this locally and it works. I also included the correct test case, to be sure

Skullbock commented 7 years ago

Mmm this is strange, did i touch something that i shouldn't have @nikosdion @tampe125 ?

nikosdion commented 7 years ago

I have yet to merge the fixes for the tests required for the new version of PHPunit. I'll have to merge that before we can see if the tests for your code work. Stay tuned.

Skullbock commented 7 years ago

Thanks, i thought i broke the hell loose :P

Il giorno ven 27 gen 2017 alle ore 10:52 Nicholas K. Dionysopoulos < notifications@github.com> ha scritto:

I have yet to merge the fixes for the tests required for the new version of PHPunit. I'll have to merge that before we can see if the tests for your code work. Stay tuned.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/pull/645#issuecomment-275627878, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDY08nRykIk2TTYs845TTg8pYqWV_yhks5rWb5cgaJpZM4LuzN6 .

-- Daniele Rosario CTO Via F.Filzi, 56/A 36051 Creazzo (Vicenza) Tel.: +39 0444 1454934 Mob: +39 328 3017134 Immagine in linea 1

nikosdion commented 7 years ago

I have adjusted the tests. Can you please fix the merge conflicts so I can marge this?

Skullbock commented 7 years ago

@nikosdion should've fixed it ;)