akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Language Strings Generator #647

Closed Skullbock closed 7 years ago

Skullbock commented 7 years ago

Hi @nikosdion i've written a small cli tool that parses through a specific FOF30 component and generates the language file for any language installed (frontend and backend) by parsing all the php + xml files that fof uses and putting them into the .ini file joomla expects. It also generates all the titles + messages related to the creation / editing / deletion of models.

Would that be useful as a part of the fof cli tool?

nikosdion commented 7 years ago

That would indeed be very helpful!

Skullbock commented 7 years ago

Ok I'll pr next week to discuss if the implementation needs adjustments ;-) Il giorno sab 28 gen 2017 alle 10:44 Nicholas K. Dionysopoulos < notifications@github.com> ha scritto:

That would indeed be very helpful!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/issues/647#issuecomment-275838354, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDY09I0PZk4ZDzZzbqzRrf4AAeiVzEdks5rWw3jgaJpZM4Lv4GO .

-- Daniele Rosario CTO Via F.Filzi, 56/A 36051 Creazzo (Vicenza) Tel.: +39 0444 1454934 Mob: +39 328 3017134 Immagine in linea 1

photodude commented 7 years ago

Looks like the 3.0 version of the parser has a minimum of php 5.5, it errors on the Travis composer install on php 5.3 and php 5.4.

Skullbock commented 7 years ago

@photodude thanks for the notice. Being a cli and dev only dependency (it's not used on the website itself, but just to generate language strings locally when you develop the component, much likely the fof controller / model generator) can we consider this viable anyway? cc @nikosdion

photodude commented 7 years ago

Can we do a multiple version install? ^2.0 | ^3.0 to cover all php versions and make Travis happy?

Skullbock commented 7 years ago

i can try but being major versions that would probably break the implementation. Not that i matters now since it's not tested anyway...

photodude commented 7 years ago

We do it with phpunit in the Joomla framework, testing with 4.8 | 5.6 since php 7 can break phpunit 4.8

Skullbock commented 7 years ago

I'll try to push this change right now let's see what happens

nikosdion commented 7 years ago

I'd say that since this is a CLI tool we can afford to have it 5.5+ (it's insane to run anything less than 7.x or 5.6 at the least on your dev machine any more). The generated code can of course run on PHP 5.3 since FOF 3.0 does still target it.

Also note that FOF 3.1 will have an increased minimum version requirement. At the very least it will be 5.4. If the trend in usage statistics is positive for higher versions I might even go for 5.6 or later.

Skullbock commented 7 years ago

Great, added this in the PR here https://github.com/akeeba/fof/pull/650