Skullbock
commented
7 years ago Sure I'll do so as soon as I get back on Monday. I made the same reasoning after submitting the pr. I would like to change the on edit method then to allow for easier override. Otherwise in the cases you need extra buttons you're forced to copy paste the entire method :-) Il giorno sab 28 gen 2017 alle 10:43 Nicholas K. Dionysopoulos < notifications@github.com> ha scritto:
The Controller task is great, but I wouldn't add it to the toolbar automatically. Save to copy only makes sense in certain cases. For example, it doesn't make sense to try and save a ticket as a copy in Akeeba Ticket System. It does, however, make sense to save a mail template. What I mean is that in the end of the day it should be up to the developer to decide where to add this button as it's very likely to be unwanted in most cases. Can you please remove the Toolbar changes and ping me?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akeeba/fof/pull/648#issuecomment-275838342, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDY01eELXpVxtavIH299C4PB4jO3Tggks5rWw3PgaJpZM4Lv931 .
-- Daniele Rosario CTO Via F.Filzi, 56/A 36051 Creazzo (Vicenza) Tel.: +39 0444 1454934 Mob: +39 328 3017134 Immagine in linea 1
The Controller task is great, but I wouldn't add it to the toolbar automatically. Save to copy only makes sense in certain cases. For example, it doesn't make sense to try and save a ticket as a copy in Akeeba Ticket System. It does, however, make sense to save a mail template. What I mean is that in the end of the day it should be up to the developer to decide where to add this button as it's very likely to be unwanted in most cases. Can you please remove the Toolbar changes and ping me?