search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Get the manifest by it's method in Joomla 3.4+ #662

Closed wilsonge closed 6 years ago

wilsonge commented 6 years ago

The function get is effectively deprecated as part of the documented change that JInstallerAdapter will no longer extend from JAdapterInstance (which has been the case since 3.4 - https://github.com/joomla/joomla-cms/blob/3.7.4/libraries/cms/installer/adapter.php#L21)

JInstallerAdapter::getManifest has been the replacement method since 3.4 - so as InstallScript/Component.php is supposed to support 3.3 and higher I've added a method exists check.

Also required for Joomla 4.0 compatibility where JInstallerAdapter::get has been removed

nikosdion commented 6 years ago

Apparently I had left this aside to look "a bit later" and then I forgot about it. Oops. Sorry, I was not ignoring you, I just genuinely forgot about this PR until now :/