search

akeeba / fof

Rapid Application Development framework for Joomla!™ 3 and 4
0 stars 0 forks source link

Fix tests due to vfsStream requirements #667

Closed photodude closed 6 years ago

photodude commented 6 years ago

Note: This patch only fixes the Build errors, builds might still fail for other reasons (like some issue with mySQLi connection on travis).

vfsStream has set their dev-master to >PHP 7.1 so we need to Fall back to release 1.6.5 to remove build errors Reference https://github.com/mikey179/vfsStream/issues/143

Note: they will be changing the package name at some point with the 2.x release https://github.com/mikey179/vfsStream/issues/144

nikosdion commented 6 years ago

Thank you! I was only running the tests locally where I have a frozen composer.lock that I've copied across all my computers. I never noticed the changes in vfsStream. Oops.

photodude commented 6 years ago

You are welcome @nikosdion. It's easy to overlook things that are not in your normal workflow (I can't count all of the stuff I've overlooked here and there).

I'm not sure what's at the bottom of this rabbit hole with the MySQLi errors and the PHPUnit 4.x segfaults. I assume its just configuration related stuff that has changed over the last year or so.