WIP: 🐛 Fix missing files when listing large buckets

akeeba / s3

No-dependencies, lightweight Amazon S3 connector implementation in pure PHP

37 stars 17 forks source link

WIP: 🐛 Fix missing files when listing large buckets #23

Closed alexander-zierhut closed 2 years ago

alexander-zierhut commented 2 years ago

When listing huge buckets, some files are missing in the listing.

[ ] Tests have to be written to confirm the bug is fixed

Signed-off-by: AlexZierhut alex@zierhut-it.de

alexander-zierhut commented 2 years ago

We have been using the following patch as a workaround since months.

akeeba_s3.patch.txt

nikosdion commented 2 years ago

You are right about the problem being there but your solution is a bit of a hack which works on your use case but is generally a bad idea. Let me try refactoring that code and come up with a better way to implement this.

nikosdion commented 2 years ago

Please see commit https://github.com/akeeba/s3/commit/6448ddf99541f3ba50f97e373ceeb5bfd42a0167 for a better solution

alexander-zierhut commented 1 year ago

Hi @nikosdion thank you for your reply and commit.

but your solution is a bit of a hack which works on your use case

That is surely true. It's a simple patch to get things running which did a great job. Thank your for writing a proper solution with an actual test!

nikosdion commented 1 year ago

You're welcome :) Thank you for the heads up and Happy New Year!