search

akeep / nanopass-framework-racket

Racket port of the nanopass-framework
MIT License
34 stars 9 forks source link

Make generated records transparent #7

Closed soegaard closed 9 years ago

soegaard commented 9 years ago

Making the generated records transparent makes debugging easier.

akeep commented 9 years ago

Hey Jens,

I've got conflicting updates from you and Leif Andersen. It looks like, Lief is making the the structs #:prefab and you are making them #:transparent. Since #:prefab implies transparent, I'm inclined to take his pull request, but if there is a reason you'd prefer #:transparent to prefab, we should talk with Lief and make sure that will work for his purposes too.

-andy:)

soegaard commented 9 years ago

:prefab is fine.

Both #:prefab and #:transparent prints the contents in the REPL.

2015-07-01 23:23 GMT+02:00 Andy Keep notifications@github.com:

Hey Jens,

I've got conflicting updates from you and Leif Andersen. It looks like, Lief is making the the structs #:prefab and you are making them

:transparent. Since #:prefab implies transparent, I'm inclined to take his

pull request, but if there is a reason you'd prefer #:transparent to prefab, we should talk with Lief and make sure that will work for his purposes too.

-andy:)

— Reply to this email directly or view it on GitHub https://github.com/akeep/nanopass-framework-racket/pull/7#issuecomment-117828232 .

Jens Axel Søgaard

akeep commented 9 years ago

Okay, sounds good, I'll mark this pull request closed and merge Leif's.

Thanks, -andy:)