search

akelleh / causality

Tools for causal analysis
MIT License
1.06k stars 128 forks source link

Small changes to allow IC to use MixedChiSquare; also a quick hack to… #15

Open stewartsiu opened 8 years ago

stewartsiu commented 8 years ago

… ChiSquared test to allow zero contingency entry, so that it can be used for testing.

stewartsiu commented 8 years ago

Hi @akelleh!

  1. On the print statement, what is your preferred mechanism of displaying info about the independence test? I just added that line when I was debugging to help myself see what it's working on.
  2. On line 33, I didn't change it because I wasn't sure if you intend ChiSquaredTest to be a standalone independence test (I seem to remember some issues with data format) or merely as a helper method for MixedChiSquaredTest.
akelleh commented 8 years ago

Hey @stewartsiu (1) It's fine to print in general, but I want to avoid adding any more print statements to master, unless they're reporting errors. We want this to be something that doesn't dump a bunch of text to stdout, which is generally bad practice (unless you call a method that specifically asks for text).

(2) That's cool. It'll work as a CIT on discrete data, so we need to make sure it's still compatible with ICs, so we need to make sure it accepts the args that ICs passes to it. Let me know if you have any questions!