Closed jattenberg closed 6 years ago
Thanks! Reviewing now ...
made some fixes/improvements
Oof, I guess I need to cut a release so that change gets picked up. In the meantime, want to change the readme back to it re-casts before initializing the CausalEffect class?
will do. let me see if that change gets picked up for this pr or if i need to make a new one
I already merged, so I think you'll want to make a new one. otherwise, I think you'll have to rebase.
On Tue, Nov 14, 2017 at 1:42 PM, josh attenberg notifications@github.com wrote:
will do. let me see if that change gets picked up for this pr or if i need to make a new one
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/akelleh/causality/pull/51#issuecomment-344356425, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrkQDOTklkC2R7M8aL4vu4DKSyYzmMuks5s2d78gaJpZM4Qdup5 .
--
Adam Kelleher | BuzzFeed | Principal Data Scientist | (843) 737-1257 | tw: @akelleh | github: akelleh
111 East 18th St., NY, NY 10003
couldn't get the code in the README to work, I think these are the appropriate changes to fix things, but not 100% positive.