search

akelleh / causality

Tools for causal analysis
MIT License
1.06k stars 128 forks source link

updates to the readme #51

Closed jattenberg closed 6 years ago

jattenberg commented 6 years ago

couldn't get the code in the README to work, I think these are the appropriate changes to fix things, but not 100% positive.

akelleh commented 6 years ago

Thanks! Reviewing now ...

jattenberg commented 6 years ago

made some fixes/improvements

akelleh commented 6 years ago

Oof, I guess I need to cut a release so that change gets picked up. In the meantime, want to change the readme back to it re-casts before initializing the CausalEffect class?

jattenberg commented 6 years ago

will do. let me see if that change gets picked up for this pr or if i need to make a new one

akelleh commented 6 years ago

I already merged, so I think you'll want to make a new one. otherwise, I think you'll have to rebase.

On Tue, Nov 14, 2017 at 1:42 PM, josh attenberg notifications@github.com wrote:

will do. let me see if that change gets picked up for this pr or if i need to make a new one

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/akelleh/causality/pull/51#issuecomment-344356425, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrkQDOTklkC2R7M8aL4vu4DKSyYzmMuks5s2d78gaJpZM4Qdup5 .

--

Adam Kelleher | BuzzFeed | Principal Data Scientist | (843) 737-1257 | tw: @akelleh | github: akelleh

111 East 18th St., NY, NY 10003

1 Most Innovative Company In The World – Fast Company

http://www.fastcompany.com/3056057/most-innovative-companies/buzzfeed-for-shaking-up-media-across-the-globe