search

akelleh / causality

Tools for causal analysis
MIT License
1.06k stars 128 forks source link

Symmetry in _apply_recursion_rule_2 #78

Open jharmse opened 4 years ago

jharmse commented 4 years ago

The function loops over edges (a,b) and checks whether it should add an arrow from a to b, but it does not check whether it should add an arrow from b to a. Note that self._g.edges() has only one entry for each unordered pair.

I tried to submit a pull request, but I apparently I can't push a new branch to the repository.

akelleh commented 2 years ago

good catch! fixed this on master -- do you have a test case to run against it?

jharmse commented 2 years ago

Thank you for fixing it. I happened to notice the issue while looking at the code, and I didn't develop a test case to show the difference.

Regards, Jorgen Harmse.

On Sat, Nov 6, 2021 at 1:58 PM Adam Kelleher @.***> wrote:

good catch! fixed this on master -- do you have a test case to run against it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akelleh/causality/issues/78#issuecomment-962495347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDUXGKMHTQENAO4UM372NLUKWCHHANCNFSM4IUNWPAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.