search

akemin-dayo / BlueMapSkinSupport

Adds proper offline skin acquisition support to BlueMap's web UI.
MIT License
8 stars 3 forks source link

fix java.lang.NoClassDefFoundError: net/skinsrestorer/shared/utils/ReflectionUtil #6

Closed menggatot closed 2 years ago

menggatot commented 3 years ago

I fix it by removing ReflectionUtil all together. according to this https://docs.oracle.com/javase/tutorial/reflect/ "Reflection is powerful, but should not be used indiscriminately. If it is possible to perform an operation without using reflection, then it is preferable to avoid using it" and because the output of getValue() is already a string, my guess is using ReflectionUtil is too redundant, so I remove it

akemin-dayo commented 2 years ago

Ah… I ended up making this change myself anyway, didn't see this PR l o l

I forget the exact reason why Reflection ended up being used there, but I'm pretty sure it had something to do with avoiding a crash due to missing symbols on some configurations during development.

That being said, the (prerelease) code was in a very different state at the time, and eventually I refactored the code to the point where the Reflection usage was actually no longer required (but I clearly forgot to remove the Reflection usage, ha…).

Thanks for the effort you put into your PR, though!!