search

akeneo-labs / EnhancedConnectorBundle

[DEPRECATED] Provides product reader with more option (choice on completeness, choice on enabled, delta based on last export time).
21 stars 11 forks source link

Attribute exclusion in product export #40

Closed axel-ducret closed 8 years ago

axel-ducret commented 8 years ago

Added ability to select attributes and associations not to export in product export

BitOne commented 8 years ago

Hey @axel-ducret !

Thanks for your contribution ! Great work ! Some cosmetic remarks and one architectural one on the processor, but otherwise, should be ok once they are fixed.

axel-ducret commented 8 years ago

Hey @BitOne !

Here are the corrections

fitn commented 8 years ago

Hi @axel-ducret,

Sorry for this late answer but we did not forget you ^^

We can't merge your PR for now. We need to check the scalability of this new feature as this bundle is used by customers with big catalog. I think this code works well on hundred of attributes but I'm pretty sure that it could not work with thousands (as findAll method is called).

However, I want to thank you for your contribution because it is a really needed (and wanted) feature and you did a great job. We will do the best to merge it (probably by the end of the month) ;)

Regards,

jmleroux commented 8 years ago

Hi @axel-ducret ,

we just forked your PR to rebase it before we can validate it. Thanks again for this great contribution.

JM

jmleroux commented 8 years ago

@axel-ducret , i've rebased your branch on master in #67 to be able to validate this great PR. Thank you again.