search

akeneo-labs / EnhancedConnectorBundle

[DEPRECATED] Provides product reader with more option (choice on completeness, choice on enabled, delta based on last export time).
21 stars 11 forks source link

[NotMergeable] Attribute exclusion #67

Closed jmleroux closed 7 years ago

jmleroux commented 8 years ago

rebase of #40

fitn commented 8 years ago

Need to remove findAll call for attributes and (maybe) twig template before merge. I started a rework locally ;)

fitn commented 8 years ago

Hi @axel-ducret

I rebased your PR to be compatible with Akeneo PIM 1.5. Unfortunately, I can't merge it because it is not scalable. It works pretty well for an hundred of attributes but if you add thousands it freezes the application. Today we already have customers with this kind of catalogs so we can't potentially break their application merging your PR.

I tried to make it scalable but Akeneo PIM components are not fully ready for that and as, in the 1.6, we should be able to choose the attributes to export, I can't take too much time on it.

However, this feature is great and I will be very pleased to help you and integrate it in the current EnhancedConnector version. Feel free to take a look at the AsyncSelectType and the family dropdown when you create a product.

Regards,

jmleroux commented 8 years ago

@fitn , time to close after two months without activity ?