akeneo-labs / EnhancedConnectorBundle

[DEPRECATED] Provides product reader with more option (choice on completeness, choice on enabled, delta based on last export time).
21 stars 11 forks source link

Use startTime instead of endTime #79

Closed Hocdoc closed 8 years ago

Hocdoc commented 8 years ago

When using endTime we may miss products that where created during the last export.

When using startTime we may have products that were already exported the last time, but this is not a big problem.

jmleroux commented 8 years ago

Hello @Hocdoc ,

Thanks for your contribution.

When using endTime we may miss products that where created during the last export.

right :+1:

When using startTime we may have products that were already exported the last time, but this is not a big problem.

I even think it's better. We can have an edge case where you export foo_product and it is updated after being exported but before the end of the job. In this case, using the startTime will export it.

jmleroux commented 8 years ago

Green build :+1:

Could you please update the changelog with a header like

1.2.2

Improvements

Hocdoc commented 8 years ago

I've updated the CHANGELOG.

jmleroux commented 8 years ago

Merged. Thx @Hocdoc