search

akeneo-labs / ExcelConnectorBundle

Akeneo Excel Connector (deprecated)
Other
16 stars 11 forks source link

Ignore attribute codes if they are empty in the Family Xlsx Iterator #28

Closed qrz-io closed 8 years ago

qrz-io commented 8 years ago

We've recently attempted to automatically generate the family sheets with formulas, but every now and then some formulas result in empty attribute code at the end of the sheet. They are not empty in excel, since there is a formula in there, but it results in an empty string.

The family iterator is currently not validating the attribute codes, so this results in The "Attribute" with code "" is unknown errors.

Adding this little condition solves the issue.

damien-carcel commented 8 years ago

Hi Cristian.

Sorry for our lack of response, we missed the GitHub notification. You PR is merged and I'm going to tag new 1.5.2 and 1.4.2 (once I cherry-pick you fix) in the afternoon. It is really nice to have external contribution, so thank you a lot!

Regards, Damien

qrz-io commented 8 years ago

No problem, thanks to you!