Open bartoszkubicki opened 1 year ago
@bartoszkubicki we have the same issue. Could you team make a pull request so this could hopefully end up in a future release?
@magentix I can see a proposal of my fix for the given issue has been added. Unfortunately, I can see you have removed two dependencies from the constructor method and you are pulling them from the object manager. This is a clear antipattern and I have no idea why you did that. Please fix it or remove my name from that class. I don't want to be linked with such poor-quality code.
@bartoszkubicki
We must be compatible with all Magento versions, the use of VisualMerchandiser classes in the constructor breaks all Magento OpenSource / OpenMage and Adobe Commerce without the module.
Note that the plugin was removed in 104.0.7 (the product sort order is not persisted with this technique).
Environment and configuration
Steps to reproduce
Expected result
Actual result
Issue was solved by out team with following plugin: