akeneo / magento2-connector-community

Akeneo Connector for Magento 2
Open Software License 3.0
81 stars 88 forks source link

Fixed date format before saving into database #646

Open Bartlomiejsz opened 1 year ago

Bartlomiejsz commented 1 year ago

Those changes fixes issue caused by https://github.com/akeneo/magento2-connector-community/commit/67f58c233ac698781054777751ad438db2d0e321

When last_success_executed_date was datetime it was saved correctly into the database. But by changing it into text Mysql is no longer fixing date format while saving into database. As result date is saved as 23-05-16 11:26:55 instead of 2023-05-16 11:26:55. When this date is used as filter in Since last successful import Products process it downloads all the products on each run of import instead of only modified.

hryvinskyi commented 1 month ago

@magentix Are there any specific reasons why this PR hasnt been added yet?