search

akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 514 forks source link

Accessing private property in child class #3803

Closed nowiko closed 7 years ago

nowiko commented 8 years ago

Hello, found a little strange issue in both adapters here. There you are trying access property $expressionBuilder. How this working?

nidup commented 8 years ago

Hi,

It's a legacy override of an old version of OroOrmFilterDatasourceAdapter, the ExpressionBuilder is instanciated here https://github.com/akeneo/pim-community-dev/blob/master/src/Oro/Bundle/FilterBundle/Datasource/Orm/OrmFilterDatasourceAdapter.php#L87

What is the issue you encountering?

nowiko commented 8 years ago

@nidup, hello, thanks for reply. It is not isssue as well, but it seems strange, that you "override" this property. It is unclearly how it is working, I mean that expressionBuilder is defined as private, so it cannot be accessed from children classs.

pierallard commented 7 years ago

Hi @NovikovViktor As there was no new activity on this post since more than 1 year, I permit myself to close the card ;) Please feel free to re-open this issue if you have issues using this code classes :)

Regards Pierre