search

akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 514 forks source link

[v1.6.3] Pim\Bundle\EnrichBundle\Form\Type\ImageType missing (possible dead code) #5048

Closed jycamier closed 7 years ago

jycamier commented 7 years ago

Since 1.6.1, the form type Pim\Bundle\EnrichBundle\Form\Type\ImageType have disappeared however the parameters is still pim_enrich.form.type.image.class is still affected to Pim\Bundle\EnrichBundle\Form\Type\ImageType and the pim_enrich_image is still declared.

nidup commented 7 years ago

Hi @eheuje !

Exact, thank you for raising this issue, we forgot to drop it! :tada:

FYI, we don't drop any existing code on already released versions to avoid any issue when applying patches on projects, however we should drop it in the upcoming 1.7 version (master branch).

Are you interested to drop these parameters and services through a pull request? I'll be happy to help you by reviewing and merging this PR.

If you're interested, I'll need that you read and sign our contributor agreement to merge the pull request https://www.akeneo.com/contributor-license-agreement/

Thank you!

nidup commented 7 years ago

Fixed! thank you @a2xchip !

aistis- commented 7 years ago

Hey guys, what is the new replacement for Pim\Bundle\EnrichBundle\Form\Type\ImageType ? Is there any other FormType which could be used for an image?

I am creating a basic CRUD where I need to add an image.

a2xchip commented 7 years ago

@aistis- ImageType is not used any more, and all symfony forms are going to be deprecated. attribute fields functionality is based on js/rest/updaters/savers/removers... You can check docs about it: https://docs.akeneo.com/1.6/cookbook/ui_customization/create_a_new_field_type.html#create-the-form-field there are architecture explanations