search

akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
951 stars 516 forks source link

Shows console error in case of missing flash message #5897

Closed wakqasahmed closed 7 years ago

wakqasahmed commented 7 years ago

I'm reporting a Bug

As shown in the snapshot, we keep getting a javascript error whenever we click on any import/export profile, in my opinion:

1) Either it should be a simple warning OR 2) If it is really critical (I don't really know why?) we should fix this by sending some message (e.g. empty string) to stop showing error on profile click.

Steps to reproduce:

1) Click Import profiles/Export profiles from Collect/Spread links in the menu. 2) Click any profile and check chrome console for error

javascript_error

wakqasahmed commented 7 years ago

Submitted a PR, please have a look and merge. https://github.com/akeneo/pim-community-dev/pull/5898

solivier commented 7 years ago

Thanks @wakqasahmed your PR has been merged. :+1: