akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 516 forks source link

ImmutableValidator has dead code in it #6089

Closed mathewrapid closed 7 years ago

mathewrapid commented 7 years ago

I'm reporting a Bug

public function getTargets() is a method of the Constraint class, not ConstraintValidator https://github.com/akeneo/pim-community-dev/blob/master/src/Pim/Component/Catalog/Validator/Constraints/ImmutableValidator.php#L64-L67

nidup commented 7 years ago

Hi @mathewrapid !

Thank you for opening the issue :tada:

Don't hesitate to open a pull request on the master to remove this method.

Cheers.